dwreeves commented on code in PR #31846:
URL: https://github.com/apache/airflow/pull/31846#discussion_r1228535137
##########
airflow/providers/databricks/hooks/databricks_sql.py:
##########
@@ -138,15 +141,39 @@ def get_conn(self) -> Connection:
)
return self._sql_conn
+ @overload
Review Comment:
Almost forgot to respond to this.
I tried excluding the overloads in the subclasses and Mypy complained about
incompatibility.
That said, I did find that 2 of the `run()` subclass methods were
superfluous, so this will help reduce the overall complexity of the code
changes I am introducing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
