[GitHub] [airflow] utkarsharma2 commented on a diff in pull request #31852: [Webserver] Use custom_operator_name instead of task_type in UI for taskinstance object

Wed, 14 Jun 2023 21:31:55 -0700 


utkarsharma2 commented on code in PR #31852:
URL: https://github.com/apache/airflow/pull/31852#discussion_r1230410781


##########
airflow/www/views.py:
##########
@@ -3083,6 +3083,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
         for ti in dag.get_task_instances(dttm, dttm):
             if ti.task_id not in task_instances:
                 task_instances[ti.task_id] = 
wwwutils.get_instance_with_map(ti, session)
+                # Need to add operator_name explicitly because it's not a 
column in task_instances model.
+                task_instances[ti.task_id]["operator_name"] = ti.operator_name

Review Comment:
   @pierrejeambrun I believe to do this we would do something like this 
   ```
   operator_name = column_property(
           select(
               func.IF(custom_operator_name is not None, custom_operator_name, 
operator)
           )
       )
   ```
   But the IF statement is not working with sqlite3. Getting below error - 
   ![Screenshot 2023-06-15 at 10 00 57 
AM](https://github.com/apache/airflow/assets/13021213/406d9af2-4c4a-4722-b809-59287a0a403f)
   
   Is there any other way to accomplish this?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to