utkarsharma2 commented on code in PR #31852:
URL: https://github.com/apache/airflow/pull/31852#discussion_r1236444888
##########
airflow/www/views.py:
##########
@@ -3083,6 +3083,8 @@ class GraphForm(DateTimeWithNumRunsWithDagRunsForm):
for ti in dag.get_task_instances(dttm, dttm):
if ti.task_id not in task_instances:
task_instances[ti.task_id] =
wwwutils.get_instance_with_map(ti, session)
+ # Need to add operator_name explicitly because it's not a
column in task_instances model.
+ task_instances[ti.task_id]["operator_name"] = ti.operator_name
Review Comment:
@uranusjr @pierrejeambrun using `column_property` raises below issue
`AttributeError: Neither 'Label' object nor 'Comparator' object has an
attribute 'nullable'` when looking for a solution ran into this thread -
https://github.com/marshmallow-code/marshmallow-sqlalchemy/issues/97
As mentioned in the thread it's fixed in `0.28.0` But we cannot upgrade to
`0.28.0` because of the below issue -
`flask-appbuilder 4.3.1 requires marshmallow-sqlalchemy<0.27.0,>=0.22.0,`
flask-appbuilder is pinned to 4.3.1 here -
https://github.com/apache/airflow/blob/fe7a1aa0962538a99f5e73dbd3890a6f210d22ed/setup.py#L292
Unfortunately even in the latest version of flask-appbuilder 4.3.2 we still
have upperbound on `marshmallow-sqlalchemy>=0.22.0, <0.27.0`
https://github.com/dpgaspar/Flask-AppBuilder/blob/9090d096f697cf03dd80ebc656a6b0e79a05adb3/setup.py#LL61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
