utkarsharma2 commented on code in PR #31887:
URL: https://github.com/apache/airflow/pull/31887#discussion_r1230900842
##########
airflow/dag_processing/processor.py:
##########
@@ -530,7 +530,13 @@ def manage_slas(cls, dag_folder, dag_id: str, session:
Session = NEW_SESSION) ->
for callback in callbacks:
cls.logger().info("Calling SLA miss callback %s", callback)
try:
- callback(dag, task_list, blocking_task_list, slas,
blocking_tis)
+ callback(
+ dag=dag,
+ task_list=task_list,
+ blocking_task_list=blocking_task_list,
+ slas=slas,
+ blocking_tis=blocking_tis,
+ )
Review Comment:
@ephraimbuddy I think it won't be a breaking change now, please check.
In the future, if the mechanism to invoke callbacks changes, the added test
cases added should fail to make sure that the notifier case will be handled as
part of those changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
