utkarsharma2 commented on code in PR #31887:
URL: https://github.com/apache/airflow/pull/31887#discussion_r1230328785
##########
airflow/dag_processing/processor.py:
##########
@@ -530,7 +530,13 @@ def manage_slas(cls, dag_folder, dag_id: str, session:
Session = NEW_SESSION) ->
for callback in callbacks:
cls.logger().info("Calling SLA miss callback %s", callback)
try:
- callback(dag, task_list, blocking_task_list, slas,
blocking_tis)
+ callback(
+ dag=dag,
+ task_list=task_list,
+ blocking_task_list=blocking_task_list,
+ slas=slas,
+ blocking_tis=blocking_tis,
+ )
Review Comment:
@ephraimbuddy Also, I think this will be a breaking change only if someone
is using `args` in a callback to get the parameters passed. But if we want to
be on the safe side we should consider it as a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
