potiuk commented on PR #31879: URL: https://github.com/apache/airflow/pull/31879#issuecomment-1592920349
BTW. Small proposal here @pankajkoti -> if you want to get more hands on, actually there should be a way to improve the "group change" case a bit. As mentioned above, when you "just" move things around in "command*_config.py" (i.e. like in this case groupping commands together) the images will not be regenerated automatically - because the `hash` generated only hashes the "click" information and not the "rich-click" information that contains the groupping information. Extending the hash to also including groups is the small thing that I did not do - but it should be entirely possible. Maybe a good way to learn how it works `by doing` (just saying). It will make it slightly easier to not forgot to force generation of the screenshots when we change grouping in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
