Lee-W commented on code in PR #31757:
URL: https://github.com/apache/airflow/pull/31757#discussion_r1231748977
##########
airflow/jobs/triggerer_job_runner.py:
##########
@@ -608,6 +609,18 @@ async def run_trigger(self, trigger_id, trigger):
self.log.info("Trigger %s fired: %s",
self.triggers[trigger_id]["name"], event)
self.triggers[trigger_id]["events"] += 1
self.events.append((trigger_id, event))
+ except asyncio.CancelledError as err:
+ trigger_timeout = trigger.task_instance.trigger_timeout
+ if trigger_timeout:
+ if not trigger_timeout.tzinfo:
+ trigger_timeout =
trigger_timeout.replace(tzinfo=timezone.utc)
+
+ if trigger_timeout < timezone.utcnow():
+ self.log.info("Trigger cancelled due to timeout")
+ raise asyncio.CancelledError("Trigger cancelled due to
timeout")
Review Comment:
This (not sure whether we should add that additional log) might be why I
thought of reraising 🤔 But I don't have a strong opinion on it. And I noticed
it might be better to change the log level from info to error for other
canceled errors as well. Let me make these changes now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
