dcoliversun commented on code in PR #31787:
URL: https://github.com/apache/airflow/pull/31787#discussion_r1234947813


##########
airflow/utils/db.py:
##########
@@ -477,6 +477,19 @@ def create_default_connections(session: Session = 
NEW_SESSION):
         ),
         session,
     )
+    merge_conn(
+        Connection(
+            conn_id="adb_spark_default",
+            conn_type="adb_spark",

Review Comment:
   > Where is `adb` coming from?
   
   `adb` is short name for `analyticdb` officially and doc is 
https://www.alibabacloud.com/help/en/analyticdb-for-mysql. short name usage is 
like 
https://www.alibabacloud.com/help/en/analyticdb-for-mysql/latest/sdk-reference
   
   > would you prefer to have this change in a separated PR?
   
   I'm ok and I will revert `db.py` in this PR. User can use other connection 
like this content in adb spark.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to