potiuk commented on code in PR #31920:
URL: https://github.com/apache/airflow/pull/31920#discussion_r1238450457
##########
docker_tests/test_prod_image.py:
##########
@@ -127,7 +127,7 @@ def test_pip_dependencies_conflict(self):
"cncf.kubernetes": ["kubernetes", "cryptography"],
"dask": ["cloudpickle", "distributed"],
"docker": ["docker"],
- "elasticsearch": ["elasticsearch", "es.elastic", "elasticsearch_dsl"],
+ "elasticsearch": ["elasticsearch"],
Review Comment:
@eladkal -> do you still want to split it ? And @Owen-CH-Leung - do you
understand what we are asking for here?
I have personally a feeling, the need for splitting such PR will be
difficult to explain to the contributors, because they have no context and
might be a bit difficult to understand what we are asking for and why and how
to do it.
I am - honestly - not sure if this is a better solution, taking into account
that the only side-effect of having this ina a single PR is that the same
change will appear in both provider and the core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
