Owen-CH-Leung commented on code in PR #31920:
URL: https://github.com/apache/airflow/pull/31920#discussion_r1238484729
##########
docker_tests/test_prod_image.py:
##########
@@ -127,7 +127,7 @@ def test_pip_dependencies_conflict(self):
"cncf.kubernetes": ["kubernetes", "cryptography"],
"dask": ["cloudpickle", "distributed"],
"docker": ["docker"],
- "elasticsearch": ["elasticsearch", "es.elastic", "elasticsearch_dsl"],
+ "elasticsearch": ["elasticsearch"],
Review Comment:
@potiuk pretty hard for me to understand as I don't have experience with
releasing airflow & airflow provider package. My guess is : it would be better
to have one PR for code change (including tests), and another PR for
deprecating the dependencies ? So that means with the code-change PR being
merged, we still have non-official elasticsearch library as dependency, just
that we are not using them ?
More specifically , the changes to `CHANGELOG.rst`, `test_prod_image.py`,
`provider_dependencies.json`, `index,rst` and etc...All go to another PR ?
I hope I'm getting it correctly but if not please explain to me. I can
accommodate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
