darkag commented on code in PR #32089:
URL: https://github.com/apache/airflow/pull/32089#discussion_r1241265014
##########
airflow/providers/vertica/hooks/vertica.py:
##########
@@ -46,5 +46,41 @@ def get_conn(self) -> connect:
else:
conn_config["port"] = int(conn.port)
+ bool_options = ["connection_load_balance", "binary_transfer",
"disable_copy_local", "request_complex_types", "use_prepared_statements"]
+ std_options = ["session_label", "backup_server_node",
"kerberos_host_name", "kerberos_service_name", "log_path", "unicode_error",
"workload", "ssl"]
Review Comment:
I've made a try setting log_level without setting log_path, default
directory turns to be / when runned by scheduler which make exexution fail
since it doesn't have root rights. But, since vertica logging is visible in dag
run logs, the log file may not be really useful, so I propose to remove the
log_path parameter (in order to remove potential security issue) and pass
/dev/null as log path when log_level is defined. Doing this we keep the
possibility to have traces from vertica client but without the inconvient to
have a log file who will contains the same informations than the dag run logs.
If it's ok for you I'll make the change in code, if not I prefer to remove
the logging parameters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
