phanikumv commented on code in PR #32089:
URL: https://github.com/apache/airflow/pull/32089#discussion_r1242290445
##########
tests/providers/vertica/hooks/test_vertica.py:
##########
@@ -47,6 +47,57 @@ def test_get_conn(self, mock_connect):
host="host", port=5433, database="vertica", user="login",
password="password"
)
+ @patch("airflow.providers.vertica.hooks.vertica.connect")
+ def test_get_conn_extra_parameters_no_cast(self, mock_connect):
+ extra_dict = self.connection.extra_dejson
Review Comment:
what is the purpose of this test? Can you please add docstring here. It will
be helpful for everyone
##########
tests/providers/vertica/hooks/test_vertica.py:
##########
@@ -47,6 +47,57 @@ def test_get_conn(self, mock_connect):
host="host", port=5433, database="vertica", user="login",
password="password"
)
+ @patch("airflow.providers.vertica.hooks.vertica.connect")
+ def test_get_conn_extra_parameters_no_cast(self, mock_connect):
+ extra_dict = self.connection.extra_dejson
+ bool_options = ["connection_load_balance", "binary_transfer",
"disable_copy_local", "use_prepared_statements"]
+ for bo in bool_options:
+ extra_dict.update({ bo: True})
+ extra_dict.update({ "request_complex_types": False})
+
+ std_options = ["session_label", "kerberos_host_name",
"kerberos_service_name", "unicode_error", "workload", "ssl"]
+ for so in std_options:
+ extra_dict.update({ so: so})
+ bck_server_node = ["1.2.3.4", "4.3.2.1"]
+ conn_timeout = 30
+ log_lvl = 40
+ extra_dict.update({"backup_server_node":bck_server_node})
+ extra_dict.update({"connection_timeout":conn_timeout})
+ extra_dict.update({"log_level":log_lvl})
+
+ self.db_hook.get_conn()
+ assert mock_connect.call_count == 1
+ args, kwargs = mock_connect.call_args
+ assert args == ()
+ for bo in bool_options:
+ assert kwargs[bo] == True
+ assert kwargs["request_complex_types"] == False
+ for so in std_options:
+ assert kwargs[so] == so
+ assert bck_server_node[0] in kwargs["backup_server_node"]
+ assert bck_server_node[1] in kwargs["backup_server_node"]
+ assert kwargs["connection_timeout"] == conn_timeout
+ assert kwargs["log_level"] == log_lvl
+ assert kwargs["log_path"] is None
+
+ @patch("airflow.providers.vertica.hooks.vertica.connect")
+ def test_get_conn_extra_parameters_cast(self, mock_connect):
+ import logging
Review Comment:
what is the purpose of this test? Can you please add docstring here. It will
be helpful for everyone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
