uranusjr commented on code in PR #31398:
URL: https://github.com/apache/airflow/pull/31398#discussion_r1244781093
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -290,6 +291,64 @@ def prepare_template(self) -> None:
if isinstance(self.parameters, str):
self.parameters = ast.literal_eval(self.parameters)
+ def get_openlineage_facets_on_start(self):
+ try:
+ from airflow.providers.openlineage.extractors import
OperatorLineage
+ from airflow.providers.openlineage.sqlparser import SQLParser
+ except ImportError:
+ return None
+
+ hook: DbApiHook = self.get_db_hook()
Review Comment:
Just curious, why is the `DbApiHook` annotation needed? (Same question
applies to a lot of code in this PR really)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
