uranusjr commented on code in PR #31398:
URL: https://github.com/apache/airflow/pull/31398#discussion_r1244782757
##########
airflow/providers/openlineage/extractors/base.py:
##########
@@ -88,16 +89,29 @@ def extract(self) -> OperatorLineage | None:
return None
def extract_on_complete(self, task_instance) -> OperatorLineage | None:
+ if task_instance.state == TaskInstanceState.FAILED:
+ on_failed = getattr(self.operator,
"get_openlineage_facets_on_failure", None)
+ if on_failed and callable(on_failed):
+ return self._get_openlineage_facets(on_failed, task_instance)
on_complete = getattr(self.operator,
"get_openlineage_facets_on_complete", None)
if on_complete and callable(on_complete):
return self._get_openlineage_facets(on_complete, task_instance)
return self.extract()
def _get_openlineage_facets(self, get_facets_method, *args) ->
OperatorLineage | None:
- facets: OperatorLineage = get_facets_method(*args)
- return OperatorLineage(
- inputs=facets.inputs,
- outputs=facets.outputs,
- run_facets=facets.run_facets,
- job_facets=facets.job_facets,
- )
+ try:
+ facets: OperatorLineage = get_facets_method(*args)
+ return OperatorLineage(
+ inputs=facets.inputs,
+ outputs=facets.outputs,
+ run_facets=facets.run_facets,
+ job_facets=facets.job_facets,
+ )
Review Comment:
Does this line generate errors caught below? If not, it would be better to
put this in an `else` block.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
