potiuk commented on PR #32089:
URL: https://github.com/apache/airflow/pull/32089#issuecomment-1612554286

   > Ok it's more clear for me. Really thanks for your response (and patience).
   
   No worries. I understand frustration - you want to add what seems a few 
lines of code yet you need to put a lot of effort to meke them at "community 
standards' and you need to learn a lot to see how you can implement the 
standards easily. 
   
   Airflow dev env is, complex, to say the least, but it's not complicated 
IMHO. It takes time to see all the moving pieces and understand which one you 
can use, and find out that it is metciculously documented with lots of examples 
and all the steps of CI/dev can be easily reproduced  locally. So especially 
when you implement a change that involves many of the parts failing you just 
need to take a bit more time to fix them all. So this is perfectly fine to need 
a bit of guidance sometimes if you are used to just submitting the code and 
merging it. We have many more steps that need to succeed in order to change 
being mergable - and once you set it up (pre-commit, breeze etc.) it's super 
easy, but the initial steps are not always obvious.
   
   The reason why it is so - we have > 2500 - most of them do not know all the 
expectations we have, and we have limited number of those who review the code - 
so our CI is the "first" reviewer and the complex set of tests and checks takes 
care of telling the contributors what needs to be fixed - instead of people 
having to do that. The result of it that every single contributor and commiter 
can rely on those things (formatting, correctness of typing, static checks, 
documentation building without warning etc. etc. and you have very small chance 
by adding a change to break work of other 2499 contributors (so to speak).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to