potiuk commented on code in PR #32309:
URL: https://github.com/apache/airflow/pull/32309#discussion_r1250913706
##########
airflow/providers_manager.py:
##########
@@ -882,7 +884,11 @@ def _add_widgets(self, package_name: str, hook_class:
type, widgets: dict[str, A
# In case of inherited hooks this might be happening several
times
continue
self._connection_form_widgets[prefixed_field_name] =
ConnectionFormWidgetInfo(
- hook_class.__name__, package_name, field, field_identifier
+ hook_class.__name__,
+ package_name,
+ field,
+ field_identifier,
+ issubclass(field.field_class, PasswordField),
Review Comment:
Yeah. You are right. I looked at how PasswordField is defined, and it's
"passwordness" is determined by the widget, so it will be better with the
wideget check - but not evrey widget has input_type, so slightly different
check is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
