potiuk commented on code in PR #32309:
URL: https://github.com/apache/airflow/pull/32309#discussion_r1252087193
##########
airflow/www/views.py:
##########
@@ -4819,8 +4835,21 @@ def process_form(self, form, is_created):
# value isn't an empty string.
if value != "":
extra[field_name] = value
-
if extra.keys():
+ sensitive_unchanged_keys = set()
+ for key, value in extra.items():
+ if value == SENSITIVE_FIELD_PLACEHOLDER:
+ sensitive_unchanged_keys.add(key)
+ if sensitive_unchanged_keys:
+ try:
+ conn = BaseHook.get_connection(conn_id)
+ except AirflowNotFoundException:
+ conn = None
+ for key in sensitive_unchanged_keys:
+ if conn and conn.extra_dejson.get(key):
+ extra[key] = conn.extra_dejson.get(key)
+ else:
+ del extra[key]
Review Comment:
I'd hesitate with getting that one in. It does not bring much value
speed/optimisation wise and I think it is slightly less readable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
