potiuk commented on PR #32355: URL: https://github.com/apache/airflow/pull/32355#issuecomment-1621100211
We just merged https://github.com/apache/airflow/pull/31712 we should likely follow the way it is implemented. @Lee-W : I think we might want to add a pre-commit with some AST parsing likely - to add a check for providers that if they are using `defferable` in operator's __init__, the default should be as implemented in https://github.com/apache/airflow/pull/31712. I think this is the only way to avoid someone accidentally not using the deferrable configuration default. We cannot rely on reviewers remembering about it. But it should be relatively easy ot write a pre-commit that would verify that and fail the build in case someone does not use it. We have a few pre-commits that use AST to inspect parsed code so you could take it as an example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
