syedahsn commented on code in PR #32355:
URL: https://github.com/apache/airflow/pull/32355#discussion_r1254996316
##########
airflow/providers/amazon/aws/operators/eks.py:
##########
@@ -582,21 +686,39 @@ def __init__(
wait_for_completion: bool = False,
aws_conn_id: str = DEFAULT_CONN_ID,
region: str | None = None,
+ deferrable: bool = False,
+ waiter_delay: int = 30,
+ waiter_max_attempts: int = 40,
**kwargs,
) -> None:
self.cluster_name = cluster_name
self.force_delete_compute = force_delete_compute
- self.wait_for_completion = wait_for_completion
+ self.wait_for_completion = False if deferrable else wait_for_completion
self.aws_conn_id = aws_conn_id
self.region = region
+ self.deferrable = deferrable
+ self.waiter_delay = waiter_delay
+ self.waiter_max_attempts = waiter_max_attempts
super().__init__(**kwargs)
def execute(self, context: Context):
eks_hook = EksHook(
aws_conn_id=self.aws_conn_id,
region_name=self.region,
)
-
+ if self.deferrable:
+ self.defer(
+ trigger=EksDeleteClusterTrigger(
+ cluster_name=self.cluster_name,
+ waiter_delay=self.waiter_delay,
+ waiter_max_attempts=self.waiter_max_attempts,
+ aws_conn_id=self.aws_conn_id,
+ region=self.region,
+ force_delete_compute=self.force_delete_compute,
+ ),
+ method_name="execute_complete",
+ timeout=timedelta(seconds=self.waiter_delay *
self.waiter_max_attempts),
+ )
if self.force_delete_compute:
self.delete_any_nodegroups(eks_hook)
self.delete_any_fargate_profiles(eks_hook)
Review Comment:
No I don't think that's necessary. Essentially, if `self.deferrable` is
True, then whatever follows after is not relevant - the execution will not pick
up from after the `if` statement. If `self.deferrable` is False, then that
doesn't necessarily mean we force `self.force_delete_compute` to be True. At
most we could add an `elif` statement, but that wouldn't change anything.
`elif` would enforce selecting only one of the 2 options, which is already
guaranteed because if deferrable mode is True, then it will not return to the
`execute` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
