vandonr-amz commented on code in PR #32274:
URL: https://github.com/apache/airflow/pull/32274#discussion_r1253600626
##########
airflow/providers/amazon/aws/hooks/athena.py:
##########
@@ -253,7 +253,7 @@ def poll_query_status(
try:
wait(
waiter=self.get_waiter("query_complete"),
- waiter_delay=sleep_time or self.sleep_time,
+ waiter_delay=self.sleep_time if sleep_time is None else
sleep_time,
Review Comment:
I think I wrote it this way to allow `sleep_time = 0`. `is None` will keep
the zero value, but `or` will replace it with the alternative, and being able
to specify a sleep time of 0 is useful in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
