vandonr-amz commented on code in PR #32274:
URL: https://github.com/apache/airflow/pull/32274#discussion_r1253606033
##########
airflow/providers/amazon/aws/operators/ecs.py:
##########
@@ -139,13 +143,12 @@ def execute(self, context: Context):
self.log.info("Cluster %r in state: %r.", self.cluster_name,
cluster_state)
elif self.deferrable:
self.defer(
- trigger=ClusterWaiterTrigger(
- waiter_name="cluster_active",
+ trigger=ClusterActiveTrigger(
cluster_arn=cluster_details["clusterArn"],
Review Comment:
yeah, maybe something to do in a base operator, because there is usually
only one trigger being built per operator, so you'd have to pack those
parameters once per operator, and use them once, and it's not really saving
anything ? Just making the code harder to read by moving the parameters away
from where they are passed ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
