uranusjr commented on code in PR #28900:
URL: https://github.com/apache/airflow/pull/28900#discussion_r1260382974
##########
airflow/models/dag.py:
##########
@@ -1394,21 +1422,30 @@ def handle_callback(self, dagrun, success=True,
reason=None, session=NEW_SESSION
:param reason: Completion reason
:param session: Database session
"""
- callbacks = self.on_success_callback if success else
self.on_failure_callback
+ callbacks, context = (
+ DAG.fetch_callback(dag=self, dagrun=dagrun, success=success,
reason=reason, session=session)
+ or None,
Review Comment:
Would be a good idea to put the function call on its own line, this comma
(and lack of) is too easy to read incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
