vincbeck commented on PR #28900: URL: https://github.com/apache/airflow/pull/28900#issuecomment-1635986869
> > Would be a good idea to change many of the functions to kwarg-only (adding a * in front of all arguments) > > I guess you refer to private functions I introduced such as `_set_duration` in `airflow/models/taskinstance.py`? Any reason why? I dont use kwargs here but they are a mirror of their associated public method and as such I can just pass the same arguments in the same order to the private function I actually ran into an issue because of the order of params and I think you are right, making these private functions kwarg only is a good idea. I just did it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
