uranusjr commented on code in PR #32525:
URL: https://github.com/apache/airflow/pull/32525#discussion_r1260452664
##########
airflow/www/security.py:
##########
@@ -56,8 +57,11 @@
"Public",
}
+# Fetch the security manager override from the auth manager
+SecurityManagerOverride =
get_auth_manager().get_security_manager_override_class()
-class AirflowSecurityManager(SecurityManager, LoggingMixin):
+
+class AirflowSecurityManager(SecurityManager, LoggingMixin,
SecurityManagerOverride): # type: ignore
Review Comment:
Instead of resorting to blanket ignore, I think we can do
```python
if TYPE_CHECKING:
SecurityManagerOverride: type = object
else:
SecurityManagerOverride =
get_auth_manager().get_security_manager_override_class()
```
(or something like this, I think the order of conditionals or the
`TYPE_CHECKING` conditional matters)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
