uranusjr commented on code in PR #32525: URL: https://github.com/apache/airflow/pull/32525#discussion_r1262300117
########## airflow/www/extensions/init_auth_manager.py: ########## @@ -0,0 +1,48 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from airflow.auth.managers.base_auth_manager import BaseAuthManager +from airflow.configuration import conf +from airflow.exceptions import AirflowConfigException + +auth_manager: BaseAuthManager | None = None + + +def init_auth_manager() -> BaseAuthManager: + """ + Initialize auth manager. + + Import the user manager class, instantiate it and return it. + """ + auth_manager_cls = conf.getimport(section="core", key="auth_manager") + + if not auth_manager_cls: + raise AirflowConfigException( + "No auth manager defined in the config. " + "Please specify one using section/key [core/auth_manager]." + ) + + return auth_manager_cls() + + +def get_auth_manager() -> BaseAuthManager: + """Get the auth manager.""" + global auth_manager Review Comment: Do we need this global object? Or we could simply decorate this function with `cache` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
