uranusjr commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1264105039
##########
airflow/models/dag.py:
##########
@@ -3380,6 +3388,8 @@ class DagModel(Base):
processor_subdir = Column(String(2000), nullable=True)
# String representing the owners
owners = Column(String(2000))
+ # Display name of the dag
+ display_name = Column(Text)
Review Comment:
Also this probably shouldn’t be Text; I believe this type has some
performance implications in some databases. Since a DAG or task ID has limited
length, we should be able to use a String instead.
##########
airflow/models/dag.py:
##########
@@ -3380,6 +3388,8 @@ class DagModel(Base):
processor_subdir = Column(String(2000), nullable=True)
# String representing the owners
owners = Column(String(2000))
+ # Display name of the dag
+ display_name = Column(Text)
Review Comment:
Also this probably shouldn’t be Text; I believe this type has some
performance implications in some databases. Since a DAG or task ID has limited
length, we should be able to use a String instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
