uranusjr commented on code in PR #32520:
URL: https://github.com/apache/airflow/pull/32520#discussion_r1264595963
##########
airflow/www/templates/airflow/task_instance.html:
##########
@@ -25,7 +25,7 @@
<hr>
<br>
<h4>
- <span class="text-muted">Task Instance:</span> <span>{{ task_id }}</span>
+ <span class="text-muted">Task Instance:</span> <span title="{{ task_id
}}">{{display_name}}</span>
Review Comment:
Backfilling `display_name` during migration would make upgrade much too slow
(and for limited benefits since most of those DAGs/tasks won’t be viewed
anyway). Implementing the fallback at the UI layer would be more useful.
Although I think we can do this one layer down, doing the fallback in the
`display_name` _property_.
##########
airflow/www/templates/airflow/task_instance.html:
##########
@@ -25,7 +25,7 @@
<hr>
<br>
<h4>
- <span class="text-muted">Task Instance:</span> <span>{{ task_id }}</span>
+ <span class="text-muted">Task Instance:</span> <span title="{{ task_id
}}">{{display_name}}</span>
Review Comment:
Backfilling `display_name` during migration would make upgrade much too slow
(and for limited benefits since most of those DAGs/tasks won’t be viewed
anyway). Implementing the fallback at the UI layer would be more useful.
Although I think we can do this one layer down, doing the fallback in the
`display_name` _property_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
