vincbeck commented on code in PR #28900: URL: https://github.com/apache/airflow/pull/28900#discussion_r1264133945
########## pyproject.toml: ########## @@ -145,7 +145,7 @@ known-third-party = [ # The Pydantic representations of SqlAlchemy Models are not parsed well with Pydantic # when __future__.annotations is used so we need to skip them from upgrading -"airflow/serialization/pydantic/*.py" = ["I002"] +"airflow/serialization/pydantic/*.py" = ["I002", "UP007"] Review Comment: Otherwise Pydantic models (in `airflow/serialization/pydantic`) are using the syntax `... | None` instead of `Optional[...]`. Despite the fact we are using the syntax `... | None` across the code, Pydantic is not compatible with it. We need to make an exception then -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
