alexott commented on code in PR #32598:
URL: https://github.com/apache/airflow/pull/32598#discussion_r1264380366
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -248,9 +248,11 @@ def _get_aad_token(self, resource: str) -> str:
azure_ad_endpoint =
self.databricks_conn.extra_dejson.get(
"azure_ad_endpoint", AZURE_DEFAULT_AD_ENDPOINT
)
+ azure_databricks_proxy =
self.databricks_conn.extra_dejson.get("databricks_proxy")
resp = requests.post(
AZURE_TOKEN_SERVICE_URL.format(azure_ad_endpoint,
tenant_id),
data=data,
+ proxies=azure_databricks_proxy,
Review Comment:
If we're doing that for AAD tokens, shouldn't we do it for "normal" HTTP
requests for APIs themselves? Or we may need to specify which `requests` calls
should be proxied.
##########
airflow/providers/databricks/hooks/databricks_base.py:
##########
@@ -248,9 +248,11 @@ def _get_aad_token(self, resource: str) -> str:
azure_ad_endpoint =
self.databricks_conn.extra_dejson.get(
"azure_ad_endpoint", AZURE_DEFAULT_AD_ENDPOINT
)
+ azure_databricks_proxy =
self.databricks_conn.extra_dejson.get("databricks_proxy")
Review Comment:
I would go with simpler name - `proxies`, or something like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
