xuky76 commented on PR #32598: URL: https://github.com/apache/airflow/pull/32598#issuecomment-1650871759
> @xuky76 I agree about "making it right". Cached property could help to simplify access to the data, but even before we need to decide about the core functionality. There are different things that needs to be taken into consideration: > > 1. Access to AAD authentication REST APIs - the piece that you added > > 2. Access to the REST API - here the things could be different depending if traffic is going via public REST API or via private link. For the latter case we don't need proxy config, so we may need to have an additional configuration specifying if we should use proxy for it or not. > > 3. Many proxies require authentication - we need to understand how it could be configured, etc. > > 4. Similar proxy configuration may need to be added to the SQL operators as well. It seems like the configuration options are quite open ended...perhaps the extra proxies field could be more nested and the AAD component just get accessed with an additional get call in the requests block? at least that way we can leave room for other proxy configurations in the future. I don't understand what you mean by 4. in relation to this issue. Should we just resolve the AAD issue and then explore this in a separate issue or are they related and inseparable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
