vandonr-amz commented on code in PR #32573:
URL: https://github.com/apache/airflow/pull/32573#discussion_r1265684530
##########
airflow/providers/amazon/aws/utils/__init__.py:
##########
@@ -18,16 +18,29 @@
import logging
import re
+import warnings
from datetime import datetime
from enum import Enum
+from airflow.exceptions import AirflowProviderDeprecationWarning
+from airflow.utils.helpers import prune_dict
from airflow.version import version
log = logging.getLogger(__name__)
def trim_none_values(obj: dict):
- return {key: val for key, val in obj.items() if val is not None}
+ from packaging.version import Version
+
+ from airflow.version import version
+
+ if Version(version) < Version("2.7"):
+ return {key: val for key, val in obj.items() if val is not None}
+ else:
+ warnings.warn(
+ "use airflow.utils.helpers.prune_dict() instead",
AirflowProviderDeprecationWarning, stacklevel=2
+ )
Review Comment:
What I mean is that users that are up to date will see this warning because
their version is going to be more recent than 2.6.
I'd like them to see this warning if it's their code calling the function
(unlikely, but I understood that we cannot just remove a function before
warning before) ; but NOT if it's called in an operator they are using, because
then they cannot do anything about it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
