vandonr-amz commented on code in PR #32573:
URL: https://github.com/apache/airflow/pull/32573#discussion_r1265689489
##########
airflow/providers/amazon/aws/utils/__init__.py:
##########
@@ -18,16 +18,29 @@
import logging
import re
+import warnings
from datetime import datetime
from enum import Enum
+from airflow.exceptions import AirflowProviderDeprecationWarning
+from airflow.utils.helpers import prune_dict
from airflow.version import version
log = logging.getLogger(__name__)
def trim_none_values(obj: dict):
- return {key: val for key, val in obj.items() if val is not None}
+ from packaging.version import Version
+
+ from airflow.version import version
+
+ if Version(version) < Version("2.7"):
+ return {key: val for key, val in obj.items() if val is not None}
+ else:
+ warnings.warn(
+ "use airflow.utils.helpers.prune_dict() instead",
AirflowProviderDeprecationWarning, stacklevel=2
+ )
Review Comment:
yes, BUT we cannot update the method usage in the provider package until 1
year in the future, because current and near future versions of the provider
package need to be back-compatible with older versions of core airflow (before
this bugfix).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
