syedahsn commented on code in PR #32563:
URL: https://github.com/apache/airflow/pull/32563#discussion_r1265972454
##########
airflow/providers/amazon/aws/waiters/stepfunctions.json:
##########
@@ -0,0 +1,36 @@
+{
+ "version": 2,
+ "waiters": {
+ "step_function_succeeded": {
+ "operation": "DescribeExecution",
+ "delay": 30,
+ "maxAttempts": 60,
+ "acceptors": [
+ {
+ "matcher": "path",
+ "argument": "status",
+ "expected": "SUCCEEDED",
+ "state": "success"
+ },
+ {
+ "matcher": "error",
+ "argument": "status",
+ "expected": "RUNNING",
+ "state": "retry"
+ },
Review Comment:
This is something that I've seen used in other config files in the [botocore
repo](https://github.com/boto/botocore/blob/develop/botocore/data/lambda/2015-03-31/waiters-2.json#L15).
There is no specific documentation about how to write these config files, but
from looking at the source code, the only states that "matter" are `success`
and `failure` (by matter, I mean they are the only states that `current_state`
is [compared
to](https://github.com/boto/botocore/blob/develop/botocore/waiter.py#L366)). By
setting the state as `retry` we are just being explicit that if we match the
`expected` state, we want the waiter to retry (although it would do that
anyways).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
