vandonr-amz commented on code in PR #32563:
URL: https://github.com/apache/airflow/pull/32563#discussion_r1263094816


##########
airflow/providers/amazon/aws/operators/step_function.py:
##########
@@ -74,9 +88,25 @@ def execute(self, context: Context):
             raise AirflowException(f"Failed to start State Machine execution 
for: {self.state_machine_arn}")
 
         self.log.info("Started State Machine execution for %s: %s", 
self.state_machine_arn, execution_arn)
-
+        if self.deferrable:
+            self.defer(
+                trigger=StepFunctionsStartExecutionTrigger(
+                    execution_arn=execution_arn,
+                    waiter_delay=self.waiter_delay,
+                    waiter_max_attempts=self.waiter_max_attempts,
+                    aws_conn_id=self.aws_conn_id,
+                    region_name=self.region_name,
+                ),
+                method_name="execute_complete",
+                timeout=timedelta(seconds=self.waiter_max_attempts * 
self.waiter_delay),
+            )
         return execution_arn
 
+    def execute_complete(self, context: Context, event: dict[str, Any] | None 
= None) -> None:
+        if event and event["status"] == "success":

Review Comment:
   hmm ok, I'd prefer the opposite then 
   ```
   if event is None or event["status"] != "success":
       raise
   ```
   here if it's none, nothing happens



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to