potiuk commented on PR #32669: URL: https://github.com/apache/airflow/pull/32669#issuecomment-1639585940
This is the most important part extracted from #32604 (I will shortly rebase #32604) on top of this one. This one DOES NOT contain any provider-related changes. Those will come as finall installment of the provider config contributed changes and is a crucial refactor to be able to add provider-contributed configurations. I rewrote a little what I have done initially after I run more thorough testing - I came back (and got friends with) using ConfigParser as "default" configuration storage (because of interpolation). I also think that having `unit_test.cfg` as source of defaults for tests is better and more readable than .yml as it was in the original PR, so I changed it back in this one. The gist of this change remains the same as described in the original PR - make `config.yaml` the ONLY source of truth for configuration defaults, keep test config entirely in the sources of airflow - and do not genarate the unittest.cfg file on the filesystem but use test configuration from memory - thus making our tests for configuraiton repeatable and rerunnable, no matter what environment they are running it (breeze, local venv, pycharm). I also included some comments from the review in #32604 by @jedcunningham @ferruzzi and @o-nikolas (some of them still will need to be addressed separately and I resolved all those that are applied). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
