Lee-W commented on code in PR #32669:
URL: https://github.com/apache/airflow/pull/32669#discussion_r1266381340
##########
airflow/cli/cli_config.py:
##########
@@ -90,7 +91,7 @@ def _check_value(self, action, value):
f"executors derived from them, your current executor:
{executor}, subclassed from: "
f'{", ".join([base_cls.__qualname__ for base_cls in
executor_cls.__bases__])}'
)
- raise ArgumentError(action, message)
+ warnings.warn(message)
Review Comment:
I am wondering why this is changed from exception to warning.
##########
airflow/config_templates/config.yml:
##########
@@ -2931,7 +2935,8 @@ kubernetes_executor:
tcp_keep_cnt:
description: |
When the `enable_tcp_keepalive` option is enabled, if Kubernetes API
does not respond
- to a keepalive probe, TCP retransmits the probe `tcp_keep_cnt number`
of times before
+ to a keepalive probe, TCP retransmits the probe `tcp_keep_cnt number` o
+ f times before
Review Comment:
```suggestion
to a keepalive probe, TCP retransmits the probe `tcp_keep_cnt
number` of times before
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
