BasPH commented on issue #5461: [AIRFLOW-4835] Refactor render_template URL: https://github.com/apache/airflow/pull/5461#issuecomment-516970713 @ashb I've addressed all your comments: - Added a method `render_template_fields` to the BaseOperator, which is called from `TaskInstance.render_templates` (which doesn't perform any logic anymore and simply calls `BaseOperator.render_template_fields`. I think eventually the whole `TaskInstance.render_templates` method could be removed, but it's being called in many tests and thus would introduce a lot more code changes, so would do that another time. - Updated the description of `BaseOperator.render_template`, hopefully it makes sense now. - Merged the uuid and objects tests into a single parameterized test. - Merged the namedtuple test into the big parameterized test, by defining the namedtuple class at the top of the script.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
