michalc commented on code in PR #32773:
URL: https://github.com/apache/airflow/pull/32773#discussion_r1271396095
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,6 +63,7 @@ def __init__(
**kwargs,
) -> None:
super().__init__(base_log_folder, filename_template)
+ self.handler: logging.FileHandler | None = None
Review Comment:
In hindsight/for future reference, maybe it should have been 3 PRs so checks
passed in all of them?
1. One for this line in wasb_task_hander.py
2. One for the change in file_task_handler.py, rebased on 1., then rebased
on main after 1. was merged
3. One for the redis task handler, rebased on 2., then rebased on main after
2. was merged?
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]