pierrejeambrun commented on code in PR #32773:
URL: https://github.com/apache/airflow/pull/32773#discussion_r1271411797
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,6 +63,7 @@ def __init__(
**kwargs,
) -> None:
super().__init__(base_log_folder, filename_template)
+ self.handler: logging.FileHandler | None = None
Review Comment:
@eladkal is right, usually we try to split core and provider PR because it
makes it harder for the release manager.
In cases where it is not possible to do so, then we don't split and try to
resolve things a cherry picking time. This can prove difficult and require many
PRs from the provider to be manually cherry picked to allow to cherry pick the
PR with core change. If it's too much effort, it can postpone the release of
this patch until next minor.
##########
airflow/providers/microsoft/azure/log/wasb_task_handler.py:
##########
@@ -62,6 +63,7 @@ def __init__(
**kwargs,
) -> None:
super().__init__(base_log_folder, filename_template)
+ self.handler: logging.FileHandler | None = None
Review Comment:
@eladkal is right, usually we try to split core and provider PR because it
makes it harder for the release manager.
In cases where it is not possible to do so, then we don't split and try to
resolve things at cherry picking time. This can prove difficult and require
many PRs from the provider to be manually cherry picked to allow to cherry pick
the PR with core change. If it's too much effort, it can postpone the release
of this patch until next minor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
