pankajkoti commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1272979047
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -321,7 +321,7 @@ def emit(self, record):
setattr(record, self.offset_field, int(time() * (10**9)))
self.handler.emit(record)
- def set_context(self, ti: TaskInstance) -> None:
+ def set_context(self, ti):
Review Comment:
The static checks were failing wrt to superclass annotations. Essentially
the return values are different between the subclass and superclass. The
superclass returns a non-None value whereas this returns None. If I specify
partly the annotation e.g. ti: TaskInstance, it still complains that it does
not match the superclass signature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
