pankajkoti commented on code in PR #32646:
URL: https://github.com/apache/airflow/pull/32646#discussion_r1274554472
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -321,7 +321,7 @@ def emit(self, record):
setattr(record, self.offset_field, int(time() * (10**9)))
self.handler.emit(record)
- def set_context(self, ti: TaskInstance) -> None:
+ def set_context(self, ti: TaskInstance) -> None: # type: ignore[override]
Review Comment:
Static checks fail otherwise saying it does not match the superclass's
set_context method, I think, primarily because of the return type annotation
mismatch
##########
airflow/providers/elasticsearch/log/es_task_handler.py:
##########
@@ -321,7 +321,7 @@ def emit(self, record):
setattr(record, self.offset_field, int(time() * (10**9)))
self.handler.emit(record)
- def set_context(self, ti: TaskInstance) -> None:
+ def set_context(self, ti: TaskInstance) -> None: # type: ignore[override]
Review Comment:
<img width="1714" alt="Screenshot 2023-07-26 at 2 01 23 PM"
src="https://github.com/apache/airflow/assets/10206082/2f3041e3-532a-4e59-96c9-64920f4f6bcb";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
