uranusjr commented on code in PR #32850:
URL: https://github.com/apache/airflow/pull/32850#discussion_r1274390039


##########
airflow/utils/helpers.py:
##########
@@ -116,6 +118,9 @@ def handler(signum, frame):
 
 def is_container(obj: Any) -> bool:
     """Test if an object is a container (iterable) but not a string."""
+    if isinstance(obj, Proxy):
+        # unwrap before checking __iter__

Review Comment:
   The comment isn’t really meaningful. Either it should explain _why_ 
unwrapping is needed, or should be removed entirely.



##########
airflow/utils/helpers.py:
##########
@@ -116,6 +118,9 @@ def handler(signum, frame):
 
 def is_container(obj: Any) -> bool:
     """Test if an object is a container (iterable) but not a string."""
+    if isinstance(obj, Proxy):
+        # unwrap before checking __iter__

Review Comment:
   The comment isn’t really meaningful. Either it should explain _why_ 
unwrapping is needed, or should be removed entirely.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to