uranusjr commented on code in PR #32850:
URL: https://github.com/apache/airflow/pull/32850#discussion_r1274542163


##########
airflow/utils/helpers.py:
##########
@@ -116,6 +118,9 @@ def handler(signum, frame):
 
 def is_container(obj: Any) -> bool:
     """Test if an object is a container (iterable) but not a string."""
+    if isinstance(obj, Proxy):
+        # unwrap before checking __iter__

Review Comment:
   The first is better than the current one but not good enough; it should 
explain why the Proxy would be considered a container if not treated specially 
(because it implements `__iter__` to forward the call to the lazily initialised 
object). The second is obviously OK.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to