Usiel commented on PR #32709: URL: https://github.com/apache/airflow/pull/32709#issuecomment-1652828733
> I am not in favor of making `include_deferred` a `required_field`, I think it can just default to `False` (as you did) and keep the code as it is. (no need for custom `include_deferred` handling and deprecation such as `_handle_missing_include_deferred`), I'm happy to rework the PR with a nullable field (with default). I agree, it does circumvent a lot of the workarounds and extra steps, especially in the last few commits in regards to backwards compatibility. Before I get started I'll let @uranusjr chime in, if there is any stronger argument to be made for keeping it as non-nullable. Thanks everyone for the reviews so far and guiding me here for my first PR on this repo. Btw, the test failure (`test_databricks.py::TestDatabricksExecutionTrigger::test_sleep_between_retries`) seems unrelated and I cannot reproduce a failure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
