andylamp commented on code in PR #32867:
URL: https://github.com/apache/airflow/pull/32867#discussion_r1276316950
##########
airflow/models/connection.py:
##########
@@ -43,6 +47,26 @@ def parse_netloc_to_hostname(*args, **kwargs):
return _parse_netloc_to_hostname(*args, **kwargs)
+def sanitize_conn_id(conn_id: str | None) -> str | None:
+ """
+ Sanitises the connection id and allows only specific characters to be
within. Namely,
+ it allows alphanumeric characters plus the symbols @,#,$,%,&,!,-,_, and ()
from 1
+ and up to 200 consecutive matches.
+
+ The character selection is such that it prevents the injection of
javascript or
+ executable bits in order to avoid any awkward behavior in the front-end.
+
+ :param conn_id: The connection id to sanitize.
+ :return: the sanitized string, `None` otherwise.
+ """
+ # check if `conn_id` or our match group is `None`
+ if conn_id is None or (res := re2.match(_RE_SANITIZE_CONN_ID, conn_id)) is
None:
+ log.warning("We failed to match `conn_id` to the allowed pattern or it
was None")
+ return conn_id
Review Comment:
it's value is then `None` which was the case before - see my comments above
by raising an exception. However, later on it will be raised anyway by SQL
Alchemy as this is a non NULLable field.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
