amoghrajesh commented on code in PR #32867:
URL: https://github.com/apache/airflow/pull/32867#discussion_r1277102003
##########
tests/models/test_connection.py:
##########
@@ -186,3 +186,57 @@ def test_parse_from_uri(
)
def test_get_uri(self, connection, expected_uri):
assert connection.get_uri() == expected_uri
+
+ @pytest.mark.parametrize(
+ "connection, expected_conn_id",
+ [
+ # a valid example of connection id
+ (
+ Connection(
+ conn_id="12312312312213___12312321",
+ conn_type="type",
+ login="user",
+ password="pass",
+ host="host",
+ port=100,
+ schema="schema",
+ extra={"param1": "val1", "param2": "val2"},
+ ),
+ "12312312312213___12312321",
+ ),
+ # an invalid example of connection id, which allows potential code
execution
+ (
+ Connection(
+ conn_id="<script>alert(1)</script>",
+ conn_type="type",
+ host="protocol://host",
+ port=100,
+ schema="schema",
+ extra={"param1": "val1", "param2": "val2"},
+ ),
+ None,
+ ),
+ # a valid connection as well
+ (
+ Connection(
+ conn_id="a_valid_conn_id_!!$$%%",
+ conn_type="type",
+ login="user",
+ password="pass",
+ host="protocol://host",
+ port=100,
+ schema="schema",
+ extra={"param1": "val1", "param2": "val2"},
+ ),
+ "a_valid_conn_id_!!$$%%",
+ ),
+ ],
+ )
+ def test_sanitize_conn_id(self, connection, expected_conn_id):
+ """
+ Ensures that the sanitized connection string works as expected.
+
+ :param connection: The connection instance
+ :param expected_conn_id: expected `conn_id` value.
+ """
Review Comment:
We do not need to have a docstring for the test methods here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
