o-nikolas opened a new pull request, #33084: URL: https://github.com/apache/airflow/pull/33084
Now that Triggerer heartbeat is configurable (via #32123), the heartbeat set on Job must use the correct config source, either Scheduler or Triggerer depending on the Job. This is noticeable in the health check apis for example. If one increased the heartrate of the Triggerer to 10s and left the scheduler at the default of 5s, one should expected heartbeats of up to heartrate*2.1 seconds (so 21s) to be acceptable for the triggerer, but instead we see in the UI a warning dialog which indicates that the last heartbeat was received 13s ago and throws the warning (this shows that it is using the default 5s seconds from the scheduler not the updated 10s seconds on the triggerer).  # NOTE: This change moves the heartbeat from a class attribute to a cached property. All tests pass and it's working correctly from what I can see. But I'm interested to hear form folks who have historical context on Job.py to double check this and let me know if they are aware of any gotchas with this approach. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> <!-- Thank you for contributing! Please make sure that your code changes are covered with tests. And in case of new features or big changes remember to adjust the documentation. Feel free to ping committers for the review! In case of an existing issue, reference it using one of the following: closes: #ISSUE related: #ISSUE How to write a good git commit message: http://chris.beams.io/posts/git-commit/ --> <!-- Please keep an empty line above the dashes. --> --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information. In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed. In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
