dstandish commented on PR #33097:
URL: https://github.com/apache/airflow/pull/33097#issuecomment-1665082460

   @bbovenzi when i added a teardown in the setup group, something weird 
happens to the graph (compare with above)
   
   If you look below, I would think that setups 1 and 2 should go to the join 
dot in the group, but they don't:
   
   <img width="998" alt="image" 
src="https://github.com/apache/airflow/assets/15932138/abe03cac-f276-491d-a7ec-1aced5b88c77";>
   
   I am not sure how to fix and I figured you'd know quickly.
   
   Dag code:
   
   ```python
   with DAG(dag_id="setup_group_teardown_group_2", start_date=pendulum.now()):
       with TaskGroup("group_1") as g1:
           @setup
           def setup_1():
               ...
   
   
           @setup
           def setup_2():
               ...
   
           @teardown
           def teardown_0():
               ...
   
   
           s1 = setup_1()
           s2 = setup_2()
           t0 = teardown_0()
           s2 >> t0
   
       with TaskGroup("group_2") as g2:
           @teardown
           def teardown_1():
               ...
   
   
           @teardown
           def teardown_2():
               ...
   
   
           t1 = teardown_1()
           t2 = teardown_2()
   
   
       @task
       def work():
           ...
   
   
       w1 = work()
       g1 >> w1 >> g2
       t1.as_teardown(setups=s1)
       t2.as_teardown(setups=s2)
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to