dstandish commented on code in PR #33102:
URL: https://github.com/apache/airflow/pull/33102#discussion_r1284123448
##########
tests/models/test_taskmixin.py:
##########
@@ -287,7 +295,8 @@ def
test_set_setup_teardown_ctx_dependencies_using_classic_tasks(dag_maker):
t3 = make_task("t3", type_="classic")
setuptask = make_task("setuptask", type_="classic", setup_=True)
teardowntask = make_task("teardowntask", type_="classic",
teardown_=True)
- with setuptask >> teardowntask:
+ with setuptask >> teardowntask as scope:
+ scope.add_task(t1, t2, t3)
Review Comment:
yeah but the whole point of these tests are the case where the task is
instantiated out of context. they were just testing the arrow-auto-add
behavior. so, now, we could probably just remove them, but they are there, and
can't hurt, and `scope.add_task` is the way to achieve this now, so, seems
appropriate to just update to use add_task and keepem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
