dstandish commented on code in PR #33102:
URL: https://github.com/apache/airflow/pull/33102#discussion_r1284131175
##########
tests/models/test_taskmixin.py:
##########
@@ -287,7 +295,8 @@ def
test_set_setup_teardown_ctx_dependencies_using_classic_tasks(dag_maker):
t3 = make_task("t3", type_="classic")
setuptask = make_task("setuptask", type_="classic", setup_=True)
teardowntask = make_task("teardowntask", type_="classic",
teardown_=True)
- with setuptask >> teardowntask:
+ with setuptask >> teardowntask as scope:
+ scope.add_task(t1, t2, t3)
Review Comment:
i.e. remove `add_task` from setupteardowncontext and taskgroup ?
##########
tests/models/test_taskmixin.py:
##########
@@ -287,7 +295,8 @@ def
test_set_setup_teardown_ctx_dependencies_using_classic_tasks(dag_maker):
t3 = make_task("t3", type_="classic")
setuptask = make_task("setuptask", type_="classic", setup_=True)
teardowntask = make_task("teardowntask", type_="classic",
teardown_=True)
- with setuptask >> teardowntask:
+ with setuptask >> teardowntask as scope:
+ scope.add_task(t1, t2, t3)
Review Comment:
I am fine with that personally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
